redshift Source #18
Merged
redshift Source #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add validation for common fields * Add the source configuration
* Add validation for common fields * Add the source configuration
* Implement source methods, add the iterator, add collumn types * Add the copyExistingData configuration field * Remove the columntypes_test.go file * Update versions of connector template and Go (#5) * Update versions of connector template and Go * Update build.yaml for git * Add new lines in the end of *.yml files, update the link to conduit-core team * Add the general configuration (#1) * Add validation for common fields (#2) * Configuration (#3) * Add validation for common fields * Add the source configuration * Implement source methods, add the iterator, add collumn types * Add the copyExistingData configuration field * Remove the columntypes_test.go file * Split the iterator logic into two different logics * Fix the variable of position, add a few comments, correct misspellings
* Add DB ping timeout * Update pingTimeout constant
* Add Source documentation * Add snapshot field to the documentation * Add known limitation
hariso
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add source
Fixes # (issue)
Quick checks: