Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config fixes; Connection handling #133

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Config fixes; Connection handling #133

merged 2 commits into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. Config fixes; Connection handling 

    Make `topicNames` config setting to be not required. Validate and error when empty.
Add gRPC trailer logging.

Move the timer in the `startCDC` go routine and use a cancel contex to signal finish.
Ensure the pubsub client is done once all recv has completed.
    @lyuboxa
    lyuboxa committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3c66ca9 View commit details
    Browse the repository at this point in the history

  2. handle empty events early

    @lyuboxa
    lyuboxa committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    69262bf View commit details
    Browse the repository at this point in the history