Initial Amazon SQS Connector #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovromazgon
reviewed
Nov 14, 2023
lovromazgon
reviewed
Nov 15, 2023
lovromazgon
reviewed
Nov 16, 2023
lovromazgon
reviewed
Nov 16, 2023
lovromazgon
reviewed
Nov 16, 2023
…t-connector-amazon-sqs into init_sqs_connector
maha-hajja
reviewed
Nov 21, 2023
hariso
reviewed
Nov 21, 2023
hariso
reviewed
Nov 21, 2023
hariso
reviewed
Nov 30, 2023
hariso
reviewed
Nov 30, 2023
hariso
reviewed
Nov 30, 2023
hariso
reviewed
Nov 30, 2023
hariso
reviewed
Nov 30, 2023
hariso
reviewed
Nov 30, 2023
hariso
reviewed
Nov 30, 2023
hariso
reviewed
Nov 30, 2023
lovromazgon
changed the title
hariso
reviewed
Dec 5, 2023
hariso
reviewed
Dec 5, 2023
hariso
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Great work @anna-cross ! I added a couple of nitpicks (we can merge without those). Please take a look at some of the unresolved comments by Maha and Lovro, maybe those are resolved now.
hariso
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft of amazon sqs connector.
Source - For all the messages in source, the connecter will pick one to send to destination, receive ack from destination and remove it from Amazon SQS.
Destination - For destination, an incoming records will be loaded into an Amazon SQS message body where record's json encoding is body and metadata are message attributes.