-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc about how to pull encrypted Nydus image with image-rs #196
Merged
arronwy
merged 2 commits into
confidential-containers:main
from
taoohong:nydus-snapshot
Jul 11, 2023
Merged
Add doc about how to pull encrypted Nydus image with image-rs #196
arronwy
merged 2 commits into
confidential-containers:main
from
taoohong:nydus-snapshot
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
taoohong
commented
Jul 1, 2023
- Fixed the bug 'read only filesystem' when start container with Nydus image rootfs.
- Add doc about how to pull encrypted Nydus image with image-rs to accelerate container startup process.
taoohong
requested review from
sameo,
jiangliu,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
July 1, 2023 15:16
taoohong
changed the title
Nydus snapshot
Add doc about how to pull encrypted Nydus image with image-rs
Jul 2, 2023
taoohong
force-pushed
the
nydus-snapshot
branch
2 times, most recently
from
July 3, 2023 06:38
67930f7
to
bc46445
Compare
dubek
reviewed
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments on the new doc:
arronwy
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @taoohong , LGTM!
Fixed the bug 'read only filesystem' when start container with Nydus image rootfs. When when doing snapshot, overley the nydus rootfs as lower dir Signed-off-by: taohong <taoohong@linux.alibaba.com>
Add doc about how to pull encrypted Nydus image with image-rs to accelerate container startup process. Signed-off-by: taohong <taoohong@linux.alibaba.com>
/retest |
All CI passed, thanks @taoohong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.