Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc about how to pull encrypted Nydus image with image-rs #196

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

taoohong
Copy link
Contributor

@taoohong taoohong commented Jul 1, 2023

  1. Fixed the bug 'read only filesystem' when start container with Nydus image rootfs.
  2. Add doc about how to pull encrypted Nydus image with image-rs to accelerate container startup process.

@taoohong taoohong changed the title Nydus snapshot Add doc about how to pull encrypted Nydus image with image-rs Jul 2, 2023
@taoohong taoohong force-pushed the nydus-snapshot branch 2 times, most recently from 67930f7 to bc46445 Compare July 3, 2023 06:38
Copy link
Member

@dubek dubek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments on the new doc:

image-rs/docs/pull_image_with_nydus.md Outdated Show resolved Hide resolved
image-rs/docs/pull_image_with_nydus.md Outdated Show resolved Hide resolved
image-rs/docs/pull_image_with_nydus.md Outdated Show resolved Hide resolved
image-rs/docs/pull_image_with_nydus.md Outdated Show resolved Hide resolved
Copy link
Member

@arronwy arronwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taoohong , LGTM!

Fixed the bug 'read only filesystem' when start
container with Nydus image rootfs. When when doing
snapshot, overley the nydus rootfs as lower dir

Signed-off-by: taohong <taoohong@linux.alibaba.com>
Add doc about how to pull encrypted Nydus image
with image-rs to accelerate container startup
process.

Signed-off-by: taohong <taoohong@linux.alibaba.com>
@taoohong
Copy link
Contributor Author

/retest

@arronwy
Copy link
Member

arronwy commented Jul 11, 2023

All CI passed, thanks @taoohong

@arronwy arronwy merged commit 7658bc6 into confidential-containers:main Jul 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants