Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kbs types #272

Closed
wants to merge 4 commits into from
Closed

Conversation

Xynnn007
Copy link
Member

  • Remove Cargo.lock from .gitignore
  • Update dep kbs-types

Related to confidential-containers/trustee#124

Attestation-Agent needs to lock the dep versions inside Cargo.lock. This
way will not influence other lib crates, as they will ignore the
Cargo.lock file.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Due to https://www.rfc-editor.org/rfc/rfc7518.html#section-6.1, RSA is
needed inside the JWK to specify the key type.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
add Cargo.lock for this workspace.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Copy link
Member

@arronwy arronwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xynnn007 LGTM!

Avoid using `bail!` macro to avoid confusion.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007 Xynnn007 marked this pull request as draft July 11, 2023 05:58
@arronwy
Copy link
Member

arronwy commented Jul 11, 2023

Seems some change duplicate with this PR: #177

@Xynnn007
Copy link
Member Author

Seems some change duplicate with this PR: #177

Oh yes. Let me close this PR. The functionality is covered by #177

@Xynnn007 Xynnn007 closed this Jul 11, 2023
@Xynnn007 Xynnn007 deleted the fix-kbs-types branch July 11, 2023 06:05
@Xynnn007 Xynnn007 restored the fix-kbs-types branch July 11, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants