Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AA: Update CcaAttester to use TSM Report ABI #595

Merged

Conversation

mathias-arm
Copy link
Contributor

The latest Arm CCA Linux guest support (see cca-guest/v2 and cca-guest/v3 branches in https://gitlab.arm.com/linux-arm/linux-cca) have added support for TSM Reports ABI.

@mythi
Copy link
Contributor

mythi commented Aug 16, 2024

@mathias-arm what is your plan to move this away from draft and get it review/merged?

@mathias-arm mathias-arm force-pushed the pr/tsm_report_arm_cca branch 2 times, most recently from 6a7a989 to 52778c2 Compare September 10, 2024 14:12
@mathias-arm mathias-arm marked this pull request as ready for review September 10, 2024 14:20
@mathias-arm mathias-arm requested a review from a team as a code owner September 10, 2024 14:20
@mathias-arm
Copy link
Contributor Author

Hi, I was waiting to see if there was additional feedback, then summer happened and I needed/wanted to rebase the changes.

@mythi
Copy link
Contributor

mythi commented Sep 10, 2024

Hi, I was waiting to see if there was additional feedback, then summer happened and I needed/wanted to rebase the changes.

ok. I guess the maintainers were waiting to get this moved away from draft first before taking a look. I'll do my final review shortly.

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor open/suggestion

attestation-agent/attestation-agent/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Copy link
Member

@dcmiddle dcmiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mythi
Copy link
Contributor

mythi commented Sep 24, 2024

@Xynnn007 @fitzthum this should be ok to merge

Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! some nits

attestation-agent/attester/src/cca/mod.rs Outdated Show resolved Hide resolved
attestation-agent/attester/src/cca/mod.rs Show resolved Hide resolved
Co-authored-by: Xynnn_ <xynnn@linux.alibaba.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
@fitzthum fitzthum merged commit b1091ed into confidential-containers:main Sep 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants