verifier/tdx: fix TdShimPlatformConfigInfo parse error comparation #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythi
reviewed
Oct 18, 2024
deps/verifier/src/tdx/claims.rs
Outdated
| ParseDescriptor, | ||
|
|
||
| #[error("Failed to parse `InfoLength`")] | ||
| ParseInfoLength, |
There was a problem hiding this comment.
AFAIU, it's more like:
Suggested change
| ParseInfoLength, | |
| ReadInfoLength(#[from] io::Error), |
There was a problem hiding this comment.
std::io:Error does not support PartialEq thus we cannot use #[from] macro. This is possible as the error information is enough.
The original unit tests use anyhow for error handling. The results are unstable because the debug format of the anyhow error might change due to different environments. This patch replace anyhow with thiserror without changing the test aim. This would give a more robust error type defination for comparation. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
mkulke
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original unit tests use anyhow for error handling. The results are unstable because the debug format of the anyhow error might change due to different environments. This patch replace anyhow with thiserror without changing the test aim. This would give a more robust error type defination for comparation.
cc @jodh-intel @fitzthum