-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Docker): add "Start Local Kafka" command/action #396
Draft
shouples
wants to merge
17
commits into
main
Choose a base branch
from
djs/local-kafka-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+855
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouples
changed the title
feat: add "Start Local Kafka"
feat(Docker): add "Start Local Kafka" command/action
Oct 16, 2024
…ic from `src/docker/*.ts` and `src/commands/docker.ts`
airlock-confluentinc
bot
force-pushed
the
djs/local-kafka-start
branch
from
October 17, 2024 15:00
74fe99d
to
5a703e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As a follow-up to #347, this PR adds the functionality for creating a
confluent-local
Kafka broker container through the Docker engine API.TODO:
localKafkaConnected.fire(false)
Any additional details or context that should be provided?
Beyond the command added in https://github.com/confluentinc/vscode/blob/djs/local-kafka-start/src/commands/docker.ts, this PR is also adding some wrappers around the basic movements we'll need going forward to check for the existence of Docker images (and pull if they don't exist), create Docker networks, create and start Docker containers.
This PR also adds a
LocalResourceWorkflow
abstract base class for creating "workflows" to start and stop local resources depending on the base image chosen by the user in our extension settings. Initially, this is just for theconfluentinc/confluent-local
Docker image, but will be extended in future PRs for supporting additional images.Associated PRs
LocalSchemaRegistry
class and update general SR handling for local instances #400Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Other
.vsix
file?