DO NOT MERGE: Precisely determine the ID of a pulled image #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
If we can't find the image we have just pulled by digest, the image was probably already removed, and returning candidate.Value could only possibly point at a _different_ image with the same tag. Instead, fail immediately. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
There's no benefit in returning multiple matches; we ideally want to return exactly the image we pulled, but even if that were hard, returning multiple guesses is not what the user asked for. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... because we now never return more than one. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
- Use the image's repo, not just the digest, to be more precise when zstd:chunked ambiguities are involved - Remove the multi-platform lookup code, it is never used Signed-off-by: Miloslav Trmač <mitr@redhat.com>
> go mod edit -replace github.com/containers/image/v5=github.com/mtrmac/image/v5@copy-resolve-destination Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on unmerged containers/image#2609 and #2202 .
Instead of computing the manifest digest of the pulled image and looking up an image by digest (which can have several matches with different contents when under attack), obtain the exact image ID directly, using a new c/image API.
Absolutely untested at this point.