Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openshift-checker 0.1.5 #45

Merged
merged 2 commits into from
May 2, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Apr 30, 2024

No description provided.

Signed-off-by: Philippe Martin <phmartin@redhat.com>
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's possible to split lines in some renderer block fields by wrapping lines

until containers/podman-desktop#6930 is fixed

image

@feloy
Copy link
Contributor Author

feloy commented Apr 30, 2024

It depends which window width we want to consider. If it is the default width, this seems reasonable, as this will make lines of ~80 characters.

But if we are considering the minimal width, this will make lines of ~50 characters, which could be weird if the window if larger.

@benoitf
Copy link
Contributor

benoitf commented Apr 30, 2024

maybe try 80 chars ?

Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy requested a review from benoitf May 2, 2024 21:10
@feloy feloy changed the title add openshift-checker 0.1.4 add openshift-checker 0.1.5 May 2, 2024
@feloy
Copy link
Contributor Author

feloy commented May 2, 2024

The README is updated with code blocks limited to 80 cols

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@benoitf benoitf merged commit 6a435e1 into containers:gh-pages May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants