Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GraphQL a little bit #149

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Update GraphQL a little bit #149

merged 1 commit into from
Dec 12, 2018

Conversation

evansiroky
Copy link
Contributor

Take some very minor and reasonable changes that were included in #144 and call it good with updating graphQL a bit.

  • Update GraphQL library from v4.2 to v11.0
  • Add limit argument to routes nestedJdbcFetcher of stops
  • Rename a few variables in JdbcFetcher so the query building makes more sense
  • Add tests for highly nested GraphQL queries

Take some reasonable changes that came out of #144 and add them here
@codecov-io
Copy link

codecov-io commented Nov 20, 2018

Codecov Report

Merging #149 into dev will increase coverage by 0.01%.
The diff coverage is 68.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #149      +/-   ##
============================================
+ Coverage     55.17%   55.18%   +0.01%     
  Complexity      731      731              
============================================
  Files           143      143              
  Lines          7176     7181       +5     
  Branches        830      830              
============================================
+ Hits           3959     3963       +4     
- Misses         2880     2881       +1     
  Partials        337      337
Impacted Files Coverage Δ Complexity Δ
...om/conveyal/gtfs/graphql/fetchers/FeedFetcher.java 79.16% <100%> (+0.9%) 4 <0> (ø) ⬇️
...in/java/com/conveyal/gtfs/graphql/GraphQLUtil.java 96.29% <100%> (ø) 6 <0> (ø) ⬇️
...a/com/conveyal/gtfs/graphql/GraphQLGtfsSchema.java 98.25% <100%> (ø) 1 <0> (ø) ⬇️
...onveyal/gtfs/graphql/fetchers/RowCountFetcher.java 67.77% <50%> (-0.41%) 11 <0> (ø)
...om/conveyal/gtfs/graphql/fetchers/JDBCFetcher.java 56.83% <67.85%> (+0.23%) 25 <14> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3de7d...88b269e. Read the comment docs.

Copy link
Contributor

@landonreed landonreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only major comment is do we need or want to keep the superNested.txt test? If I remember correctly, we seemed to think that it was testing queries that we wouldn't expect to see in the wild.

@abyrd
Copy link
Member

abyrd commented Dec 12, 2018

My sense is that the super-nested query could be good for ensuring that the mechanism works properly - if it's a test of stability and functionality then it makes sense. I don't think it should be timed or have its performance otherwise measured though, as that could lead us to make compromises or time investments in development that do not improve our actual use cases.

As said in a comment on #144, the contrived query is still great as a unit test case, for verification of the results against expected output to ensure that the code does what it's intended to do.

@landonreed landonreed merged commit abbd53b into dev Dec 12, 2018
@landonreed
Copy link
Contributor

🎉 This PR is included in version 4.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants