-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GraphQL a little bit #149
Conversation
Take some reasonable changes that came out of #144 and add them here
Codecov Report
@@ Coverage Diff @@
## dev #149 +/- ##
============================================
+ Coverage 55.17% 55.18% +0.01%
Complexity 731 731
============================================
Files 143 143
Lines 7176 7181 +5
Branches 830 830
============================================
+ Hits 3959 3963 +4
- Misses 2880 2881 +1
Partials 337 337
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Only major comment is do we need or want to keep the superNested.txt
test? If I remember correctly, we seemed to think that it was testing queries that we wouldn't expect to see in the wild.
My sense is that the super-nested query could be good for ensuring that the mechanism works properly - if it's a test of stability and functionality then it makes sense. I don't think it should be timed or have its performance otherwise measured though, as that could lead us to make compromises or time investments in development that do not improve our actual use cases. As said in a comment on #144, the contrived query is still great as a unit test case, for verification of the results against expected output to ensure that the code does what it's intended to do. |
🎉 This PR is included in version 4.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Take some very minor and reasonable changes that were included in #144 and call it good with updating graphQL a bit.