Use times from transfers.txt #641 #642
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are in a new array so they can later be interpreted together with transfersForStop found through the OSM network.
pre-transfer and post-transfer arrival time updates now separate
|
One thing that remains here to make this production-ready is to ensure we handle the interactions with scenarios being applied. |
|
Let's make sure to test with the MBTA's feed, which includes transfers and pathways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #641. If transfers.txt is present it is currently expected to contain only stop-to-stop transfers of type 2, and those transfers completely replace the ones that would be generated from paths through OSM. It must be an exhaustive list of all transfers in the network (which is provided by some external GTFS-generating tools). Many of these characteristics must be made optional, but we'll need a mechanism to configure that (#644).