Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue removal duplicate code #48

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

svenwillger
Copy link

Code duplications have been removed and other TODOs have been addressed e.g. to clarify variable names

Copy link
Member

@ptrebert ptrebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good with very minor changes needed before acceptance - thanks for making that more clean!

cubi-tools/prototypes/update_metadata.py Outdated Show resolved Hide resolved
cubi-tools/prototypes/update_metadata.py Outdated Show resolved Hide resolved
cubi-tools/prototypes/update_metadata.py Outdated Show resolved Hide resolved
@svenwillger
Copy link
Author

All requested changes made

@ptrebert
Copy link
Member

My comment to the last commit 98f01e7 is the same question as in the current issue #51

@svenwillger svenwillger force-pushed the issue_removal-duplicate-code branch 2 times, most recently from 03b651d to 62513e9 Compare April 29, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants