Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsigned scheme numbers #84

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Unsigned scheme numbers #84

merged 6 commits into from
Jan 29, 2024

Conversation

cabo
Copy link
Member

@cabo cabo commented Jan 21, 2024

This PR moves the scheme number registry to unsigned integers and makes it easier to describe Proxy-Scheme-Number.

Support for additional CoAP Options has not yet been added.

| -8 | coaps+tcp | \[RFC-XXXX] |
| -9 | coap+ws | \[RFC-XXXX] |
| -10 | coaps+ws | \[RFC-XXXX] |
| CRI scheme number | URI scheme | Reference |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the updated names of the registry columns later on, the names of the columns here should be "CRI scheme number value" and "URI scheme name".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the "value" from the IANA registry entry definition -- this seems redundant to me.

| -9 | coap+ws |
| -10 | coaps+ws |
{: #scheme-map title="Mapping CRI scheme ids and URI scheme names"}
| CRI scheme number | URI scheme name |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the updated names of the registry columns later on, the name of the first column here should be "CRI scheme number value".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See above)

2. Translate the scheme-id into a URI scheme name as per
{{scheme-id}} and
{{scheme-map}}; if a scheme-id that corresponds to a scheme
number not in this list is being used,
fail this algorithm.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This covers the case where the scheme section is a scheme-id. Shouldn't this step cover also the case where the scheme section is a scheme-name instead? That would also need to check whether that scheme-name is among those listed in the table above, and, if not, to fail the algorithm.

Copy link
Member Author

@cabo cabo Jan 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we want to make the use of the scheme-id mandatory if that exists?
For all entries in the table, scheme-name is not allowed then; so it seems scheme-name is never allowed in this procedure.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember considering this detail before but it makes sense, as now also in the latest text.

unsigned integer that represents the CRI scheme-number (which relates to
a CRI scheme-id as defined in {{scheme-id}}).
For instance, the scheme name "coap" has the scheme-number 0 and is
represented as an unsigned integer by a zero-length CoAP Option value.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a reference to Section 3.2 of RFC 7252?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@cabo cabo merged commit 2c6b22f into main Jan 29, 2024
2 checks passed
@cabo cabo deleted the unsigned-scheme-numbers branch January 29, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants