Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

balun example: Use two artworks #87

Merged
merged 1 commit into from
Jun 2, 2024
Merged

balun example: Use two artworks #87

merged 1 commit into from
Jun 2, 2024

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Jun 1, 2024

If annotated as cbor-diag, the artwork should be valid EDN (at least for a CBOR sequence), but the two lines on their own are not.

@chrysn
balun example: Use two artworks
e0571e9 
If Annotated as cbor-diag, the artwork should be valid EDN (at least for
a CBOR sequence), but the two lines on their own are not.
cabo
cabo approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@cabo cabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary for correctness.
Text around the examples already works with this change.

@cabo cabo merged commit b3bf59a into main Jun 2, 2024
2 checks passed
@cabo cabo deleted the no-two-edn branch June 2, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabo cabo cabo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrysn @cabo