kola/test: update rhcos upgrade test to new s3 dir #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally RHCOS only had one stream named after the OCP major minor version. Around the 4.12 timeframe, the ability to produce concurrent RHCOS versions based on different RHEL content was introduced. This changed the stream name used in the mirror where this test downloads the latest released RHCOS version. Since the stream name is not in the build metadata, the RHEL version portion of the stream name can only be inferred from the RHCOS version string. This may be cause issues when there is a three digit RHEL version.
jlebon
approved these changes
May 19, 2023
| ocpVersionF := fmt.Sprintf("%s.%s", ocpVersion[:1], ocpVersion[1:]) | ||
| // The stream name isn't anywhere in the build so we can only infer | ||
| // the RHEL version from the RHCOS version string. This will break | ||
| // on three digit versions like 10.1 or 9.10. |
|
/cherry-pick rhcos-4.13 |
|
@mike-nguyen: new pull request created: #3482 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally RHCOS only had one stream named after the OCP major minor version. Around the 4.12 timeframe, the ability to produce concurrent RHCOS versions based on different RHEL content was introduced. This changed the stream name used in the mirror where this test downloads the latest released RHCOS version.
Since the stream name is not in the build metadata, the RHEL version portion of the stream name can only be inferred from the RHCOS version string. This may be cause issues when there is a three digit RHEL version.