chore: add ValidateBasic for MsgSendPacket #7468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
DimitrisJim
approved these changes
Oct 15, 2024
| } | ||
|
|
||
| if len(msg.PacketData) != 1 { | ||
| return errorsmod.Wrapf(ErrInvalidPacketData, "packet data must be of length 1, got %d instead", len(msg.PacketData)) |
There was a problem hiding this comment.
partially also addreses #7390 (can close it after validation is done for all msgs)
| @@ -6,6 +6,7 @@ import ( | |||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
|
|
|||
| clienttypes "github.com/cosmos/ibc-go/v9/modules/core/02-client/types" | |||
| channeltypesv1 "github.com/cosmos/ibc-go/v9/modules/core/04-channel/types" | |||
There was a problem hiding this comment.
feels weird mixing these personally? Would prefer if we just moved over all errors (i.e dunno what the error code for this error is? it might conflict with one we define in errors.go for chan/v2)
There was a problem hiding this comment.
We were discussing this with @chatton and thought about importing for now and then having a cleanup issue about moving everything to v2. Though I'm with doing it now if we prefer
There was a problem hiding this comment.
perfectly fine with me as long as there's an issue to track it 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #7466
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.