Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting issues #43

Merged
merged 6 commits into from
Jul 12, 2021
Merged

Fix linting issues #43

merged 6 commits into from
Jul 12, 2021

Conversation

ethanfrey
Copy link
Contributor

@ethanfrey ethanfrey commented Jul 12, 2021

Part of #42

  • Add cargo fmt and cargo clippy to CI
  • Fix fmt issues
  • Fix clippy issues
  • Remove #![allow(dead_code)] and #![allow(unused_imports)] from lib.rs

@ethanfrey
Copy link
Contributor Author

@DaviRain-Su can you please review this.

While trying to address some of the clippy warnings (and running 1.42 locally to get the same as the CI), I realized the ics23.rs file was manually editted and doesn't match what comes from cargo protoc, which will cause issues in the future keeping them in sync. I tried regenerating it with the script and got all kinds of errors, even in std mode.

Otherwise the rest was just making clippy happy basically

@ethanfrey ethanfrey merged commit 51fb73d into master Jul 12, 2021
@ethanfrey ethanfrey mentioned this pull request Jul 12, 2021
4 tasks
@ethanfrey ethanfrey deleted the 42-cleanup-start branch July 12, 2021 14:29
@DaviRain-Su DaviRain-Su mentioned this pull request Jul 19, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant