Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ING-935: Added support for various timing and counting metrics. #213

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

brett19
Copy link
Member

@brett19 brett19 commented Oct 17, 2024

This also refactors our error conversion to occur as a middleware such that appropriate error information is produced by our stats counting middleware. Additionally, we have updated our OpenTelemetry library version.

Westwooo
Westwooo previously approved these changes Oct 21, 2024
Copy link
Contributor

@Westwooo Westwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one typo

gateway/dapiimpl/proxy/proxy.go Outdated Show resolved Hide resolved
Brett Lawson added 4 commits October 22, 2024 12:59
This also refactors our error conversion to occur as a middleware such that
appropriate error information is produced by our stats counting middleware.
Additionally, we have updated our OpenTelemetry library version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants