-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AV-86224] Generated docs for Terraform V1.3.0 #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-atri Maybe I missed changes to index.md. Could not find in PR We should update the example usage
https://registry.terraform.io/providers/couchbasecloud/couchbase-capella/latest/docs#example-usage-2
…s and activity logs in the new feature list
@rajagp Updated the Index.md file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few wording/punctuation changes. Waiting on a quick look over by @simon-dew. Should be good to go after that. I'll have this approved by EoD (EST) max - hopefully sooner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repeated text "see below for nested schema" looks generated. Is it configurable at all? I have some minor thoughts about the capitalization and punctuation of that phrase, but it's no blocker.
Other than that, I have nothing to add to @Rebecca-Martinez007 's comments
… team Co-authored-by: Rebecca Martinez <167447972+Rebecca-Martinez007@users.noreply.github.com>
Co-authored-by: Rebecca Martinez <167447972+Rebecca-Martinez007@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit with the new sentence added for the deprecated field. Not a blocker, just a small suggestion. Thank you @a-atri !
Simon also left a small comment about the " (see [below for nested schema] " sentence.
Co-authored-by: Rebecca Martinez <167447972+Rebecca-Martinez007@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simon-dew we need to get this approval out, but @a-atri said we'd incorporate your feedback in the next Terraform release. I'm giving the approval here to move forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
04506dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…cket * origin/main: AV-78889 - VNET peering azure (#216) Av 87139 fix gorunner version (#232) Av 87139 fix gorunner version (#231) Av 87139 fix gorunner version (#230) AV-87139 fix gorunner version (#229) Updating the version for gorunner (#228) AV-87077 | handle computed values in acc test (#227) [AV-86105] initialized autoexpansion field with null value (#226) [AV-86503] Updated the changelog (#221) [AV-86224] Generated docs for Terraform V1.3.0 (#220) [AV-86845] Deprecate the `configurationType` attribute in the cluster resource (#222) Bump github.com/hashicorp/terraform-plugin-go from 0.22.1 to 0.23.0 (#193) Bump github.com/hashicorp/terraform-plugin-framework from 1.6.1 to 1.9.0 (#201)
Jira
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Type of Change
Manual Testing Approach
How was this change tested and do you have evidence? (REQUIRED: Select at least 1)
Testing
Testing
Required Checklist:
Further comments