feat: RealTimeQueries component #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptbrowne
approved these changes
Jul 22, 2020
| ) | ||
| ) | ||
| }, | ||
| [client] |
There was a problem hiding this comment.
I think that if the callback took client, we could have this whole function outside the component.
dispatchChange(client, document, mutationDefinitionCreator)
And then it would not be necessary to have a useCallback
| }) | ||
|
|
||
| unmount() | ||
| expect(client.plugins.realtime.unsubscribe).toHaveBeenCalledTimes(3) |
There was a problem hiding this comment.
Nit: It'd be nice to be able to check if the realtime doesn't have any listener anymore. Here the 3 is hardcoded and will need to change with the implementation. I don't think that's possible with the realtime current API though.
ptbrowne
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the RealTimeQueries component from drive to cozy-client, allowing documents of a given doctype to stay up to date through the realtime plugin.