File openings inside new tab #2521
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Feb 24, 2022
| onFolderOpen(attributes.id) | ||
| console.log('is directory') | ||
|
|
||
| if (event.ctrlKey || event.metaKey || event.shiftKey) { |
There was a problem hiding this comment.
it seems that you build an href for a folder https://github.com/cozy/cozy-drive/pull/2521/files#diff-66f571a15fdeccd6293e111e9483d731a1d8a1bddf527123ece478a9605e12bfR121 why do you need to check the event key?
Crash--
reviewed
Feb 24, 2022
| let buildHref = '' | ||
| if (isFolder(file)) { | ||
| buildHref = `/#${folderUrlToNavigate(file.id)}` | ||
| } else if (isNote(file)) { |
There was a problem hiding this comment.
All these helpers method should already been in https://github.com/cozy/cozy-client/blob/master/packages/cozy-client/src/models/file.js#L36-L50 I think
|
The thing I dislike here is that we still have several ways to handle navigation. Sometimes we will have an href, so we'll be able to make a right click and use browser action, sometimes not since the href will be empty. Right? |
note files are handled in createFileOpeningHandlers
trollepierre
force-pushed
the
native-opening
branch
from
bbc2279
to
5ca4236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles most of the case I found:
Handle:
But has not been cleant / tested at all.
comment about this gif:
the link below the anchor is wrong (it's the same than the file of the table cell) => ❌ you can see on the below left corner on my browser
when Cmd + Click, we have the expected feature (folder opened in a new tab) => ✅ I arrived inside the test folder
when right click, opening, we open the file instead of the folder => ❌ I arrived on the Recent gif, instead of the folder test
on click on Notes / Shortcut, this needs the big refactor "Don't use on click, use only anchor - prefetch (query?)"