Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support move for encrypted files #2609

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

paultranvan
Copy link
Contributor

This adds the possiilbity to move files from/to an encrypted folder.

3 scenarios are supported:

  • From a non-encrypted folder to an encrypted folder
  • From an encrypted folder to a non-encrypted folder
  • From an encrypted folder to another encrypted folder

Note we do not support the moving of non-encrypted folder to an
encrypted one, because of the potential cost if it has a deep hierarchy
and/or many files. However, the moving of an encrypted folder to is
supported for both non-encrypted and encrypted folder, as the files remain
encrypted with the same encryption key.

We now differenciate encryption key from decryption key, to add some
context. This is useful to better understand when a file is decrypted or
encrypted, even if it's with the same key.
These methods are useful when moving an existing file to a different
location, with a different encryption context.
@paultranvan paultranvan force-pushed the moveitmoveit branch 3 times, most recently from 926334e to c170874 Compare May 27, 2022 14:54
This adds the possiilbity to move files from/to an encrypted folder.

3 scenarios are supported:
- From a non-encrypted folder to an encrypted folder
- From an encrypted folder to a non-encrypted folder
- From an encrypted folder to another encrypted folder

Note we do not support the moving of non-encrypted folder to an
encrypted one, because of the potential cost if it has a deep hierarchy
and/or many files. However, the moving of an encrypted folder to is
supported for both non-encrypted and encrypted folder, as the files remain
encrypted with the same encryption key.
@JF-Cozy
Copy link
Contributor

JF-Cozy commented May 30, 2022

@paultranvan CI red ?

@paultranvan
Copy link
Contributor Author

@JF-Cozy Yes, I had many issues because of the cozy-keys-lib mock :( I thought it was fixed, but not everywhere obviously, I have to check that.

@trollepierre trollepierre removed their request for review September 28, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants