fix: Clear console errors #244
Conversation
acezard
force-pushed
the
fix/clear-console-errors
branch
from
cc73bf5
to
e078471
Compare
package.json
Outdated
| @@ -57,7 +57,7 @@ | |||
| "dependencies": { | |||
| "@atlaskit/icon": "21.1.0", | |||
| "@atlaskit/media-core": "32.2.0", | |||
| "@material-ui/core": "4.12.3", | |||
| "@material-ui/core": "4.11.4", | |||
There was a problem hiding this comment.
it is required with the version of cozy-ui we use
| const EditorCorner = ({ doc, isPublic, isReadOnly, title }) => { | ||
| const { t } = useI18n() | ||
| if (!isPublic) return <SharingWidget file={doc.file} title={title} /> | ||
| else if (isReadOnly) { | ||
| return ( | ||
| <Tooltip title={t('Notes.Editor.read_only')}> | ||
| <Icon icon="lock" color="var(--primaryTextColor)" /> | ||
| <ForwardedIcon icon="lock" color="var(--primaryTextColor)" /> |
There was a problem hiding this comment.
Why not updating cozy-ui in order to forwardRef by default on Icon? 🤔
There was a problem hiding this comment.
I don't remember why I didn't choose to update cozy-ui, maybe there were more problems. I can do that though
There was a problem hiding this comment.
Did you created the issue on cozy-ui? Can you link it in the code?
There was a problem hiding this comment.
I didn't create an issue yet, the build is failing with the latest cozy-ui for a different reason (konnector related)
There was a problem hiding this comment.
I mean, I'm not sure the forwardRef error exists with the latest cozy-ui (that doesn't work on cozy-notes right now, I prefered delivering the fixes instead)
There was a problem hiding this comment.
I'm pretty sur the issue still exist in the latest UI's version
There was a problem hiding this comment.
I will check on the latest version after cozy-notes is delivered
|
Did you created the issue of cozy-sharing side? It is already created so you can link to it form here? |
|
màj cozy-ui |
acezard
force-pushed
the
fix/clear-console-errors
branch
from
e078471
to
34373cf
Compare
|
Update: cozy-ui update is too complex, leaving it as is for now |
acezard
force-pushed
the
fix/clear-console-errors
branch
from
34373cf
to
8db2552
Compare
acezard
force-pushed
the
fix/clear-console-errors
branch
from
8db2552
to
7d41d04
Compare
Clearing small bugs that polluted the console. There is still one:
But it's not possible to fix it from cozy-notes, it's a cozy-sharing issue.