Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove passwords.can-share-organizations flag on folders display #76

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Dec 22, 2021

⚠️ this PR is draft until we find a way to handle konnectors with folders


Folders are now displayed for everyone, so the flag has been removed
from code responsible for displaying folders

Share feature should stay behind a flag, so we added a flag on it
(before this button was not accessible as the flag was placed on parent
component)


With this PR, all users can now :

  • See folders list on the left navigation pane and navigate through them
  • Click on the "add folder" icon (+) on the folder list
  • Click on the "delete folder" icon on the folder list
  • Click the "share cipher" button when editing a cipher in order to add it to an existing folder

Users still cannot (hidden behind passwords.can-share-organizations flag) :

  • See the Cozy Share button on a folder view
  • See the Security code button on the left navigation pane (this is used only when receiving a sharing)

Folders are now displayed for everyone, so the flag has been removed
from code responsible for displaying folders

Share feature should stay behind a flag, so we added a flag on it
(before this button was not accessible as the flag was placed on parent
component)
@Ldoppea Ldoppea marked this pull request as draft December 22, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant