feat: Add check-locales script #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Aug 31, 2020
There was a problem hiding this comment.
Shouldn't we add this to cozy-scripts command/actions? https://github.com/cozy/create-cozy-app/blob/master/packages/cozy-scripts/bin/cozy-scripts.js#L120-L128
By doing it, we can do cozy-script check-locales and enjoy this feature :)
ptbrowne
force-pushed
the
check-locales
branch
2 times, most recently
from
9a09d5f
to
d3fde81
Compare
|
Done |
y-lohse
approved these changes
Aug 31, 2020
|
This is required by cozy-scripts. The current system for loading scripts is not optimal
But I won't address those points in this PR (issue created #1345) |
|
How do other scripts to have an extension? |
ptbrowne
force-pushed
the
check-locales
branch
from
d3fde81
to
88e9d9e
Compare
|
Oups, my mistake, I thought I had seen that the scripts did not have any extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script checks two locale (JSON) files and outputs the differing
keys. It exits 1 if there are keys that differs. It is used to check
whether a JSON file is up-to-date against another one.