-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[health] Add support for RESPIRATORY_RATE and PERIPHERAL_PERFUSION_INDEX #579
Conversation
@@ -254,6 +260,7 @@ enum HealthDataUnit { | |||
|
|||
// Other units | |||
BEATS_PER_MINUTE, | |||
RESPIRATIONS_PER_MINUTE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RESPIRATIONS_PER_MINUTE, | |
COUNT_PER_MINUTE, |
all future /minute types could make use of it then. Just my opinion, I don't own or work on this repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the heart rate pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, mainly wanted to raise the discussion here. The heart rate is something that cannot be changed without breaking compatibility that's why I thought this might be worth a thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we have so few data types with this that I think it is okay to have some overlap, especially since the data type can be used to display additional context as in the example app. If the number of similar data types grows, this topic should be revisited.
Thank you for the PR, it will be included in the upcoming release! |
No description provided.