Attempt to fix Health Connect on Android 14 #834

eliasteeny · 2023-11-17T17:11:40Z

This pull request addresses the "Activity not found" error encountered when attempting to open the Health Connect permissions screen on Android 14. The issue was resolved by migrating from the old startActivityForResult method to the new API, registerForActivityResult.

Introduced a limitation for the Main app's activity: it should extend FlutterFragmentActivity instead of FlutterActivity. This adjustment allows casting from Activity to ComponentActivity for accessing registerForActivityResult.

Note: As a non-experienced Android/Kotlin developer, any suggestions for improvements or alternative approaches are welcome especially regarding FlutterFragmentActivity.

chadpav · 2023-11-18T14:43:16Z

I was able to pull down this PR branch and verify the functionality work. The code looks reasonable to me.

This PR resolves Issue #800

Thank you @eliasteeny

chadpav

Solution works and code LGTM. I think we should add some documentation to the readme though. (I submitted a PR to your branch with proposed ReadMe updates)

NOTE: I'm not a maintainer so my approval means nothing. :)

chadpav · 2023-11-18T14:45:29Z

packages/health/example/lib/main.dart

-        0.0, HealthDataType.SLEEP_AWAKE, earlier, now);
-    success &= await health.writeHealthData(
-        0.0, HealthDataType.SLEEP_DEEP, earlier, now);
+    // success &= await health.writeHealthData(


Are these changes relevant to the PR?

Yeah for some reason adding the sleep records is failing stating that it is an unsupported type. Although it is working on Android 13 and below.

chadpav · 2023-11-18T14:45:43Z

packages/health/example/lib/util.dart

-  HealthDataType.SLEEP_DEEP,
-  HealthDataType.SLEEP_REM,
-  HealthDataType.SLEEP_SESSION,
+  // HealthDataType.SLEEP_AWAKE,


Are these changes relevant?

Fetching the SLEEP data is crashing the app with the same error as writing.

I checked out this PR, uncommented the SLEEP lines, and i can read sleep data without a crash. I am running Android 14.

@eliasteeny could you please double check if this error still occurs on your device and if so, tell us your OS version and setup?

I got a closer look. I did not have a wearable so was reading only sleep session data (time asleep, one data point) and that worked fine. I get the crash now that i have a wearable and i try to read the stages. The issue seems to be that SleepStageRecord object no longer exists in Android 14. Instead there is a list in the SleepSessionRecord. You can see this sample code in https://developer.android.com/health-and-fitness/guides/health-connect/develop/sessions

suspend fun readSleepSessions(
healthConnectClient: HealthConnectClient,
startTime: Instant,
endTime: Instant
) {
val response =
healthConnectClient.readRecords(
ReadRecordsRequest(
SleepSessionRecord::class,
timeRangeFilter = TimeRangeFilter.between(startTime, endTime)
)
)
for (sleepRecord in response.records) {
// Retrieve relevant sleep stages from each sleep record
val sleepStages = sleepRecord.stages
}
}

The convertRecord function returns a single record and now it should return many, not sure how to handle this with the way it works now?

I created a pull request on your fork @eliasteeny. I tested it on Android 13 and Android 14, both were able to pull both SLEEP_SESSION (total sleep time only) and individual sleep stages.

I did not test writing though, i don't have an app that would do that.

packages/health/example/android/app/src/main/kotlin/cachet/plugins/example_app/MainActivity.kt

packages/health/example/android/app/src/main/AndroidManifest.xml

Update README.md for Android 14

Letalus · 2023-12-15T07:57:22Z

any updates on this PR? This is a critical bug for all android 34 devices

hoffmatteo · 2024-01-02T17:34:27Z

Hi, due to other projects and Christmas I was not able to properly evaluate it, I will do it this week though since it is an urgent issue.

Letalus · 2024-01-08T08:05:19Z

@hoffmatteo I hope you had a great start in the new year. Just for an update, where you able to review @eliasteeny PR and have any comments on it?

madhav-sunil · 2024-01-09T06:02:12Z

Hi, is there any way to keep FlutterActivity instead of FlutterFragmentActivity?
I'm currently using a custom implementation of the package so any change is acceptable.
PS: I was able to open the Health connect settings to by using the health connects app id. Any thoughts on that..

private fun manageHealthAppPermission() {
val intent =
context!!.packageManager.getLaunchIntentForPackage("com.google.android.apps.healthdata")
checkAvailability()
if (healthConnectAvailable && intent !== null) {
context!!.startActivity(intent)
}
}

madhav-sunil · 2024-01-10T10:53:17Z

packages/health/android/src/main/kotlin/cachet/plugins/health/HealthPlugin.kt

+        if ( healthConnectAvailable) {
+            val requestPermissionActivityContract = PermissionController.createRequestPermissionResultContract()
+
+            healthConnectRequestPermissionsLauncher =(activity as ComponentActivity).registerForActivityResult(requestPermissionActivityContract) { granted ->


Shouldn't we use FlutterFragmentActivity instead of ComponentActivity

We need the ComponentActivity in order to use the new api function registerForActivityResult, FlutterFragmentActivity is built upon the new Android apis which can be casted to a ComponentActivity. If you try to cast FlutterActivity to a ComponentActivity it will throw an error.

Alejandroem · 2024-01-14T06:02:06Z

I have downloaded this fork and used the dependency as a reference from the download. And I can confirm this fix works. It will send me to the Health Connect Dialog to confirm the permissions and I can go from there.

I would advise anyone to do this until the package is properly updated. Thank you @eliasteeny you saved my app 💪🏻

tomassasovsky · 2024-01-17T16:50:58Z

Getting an error while testing on a Samsung Galaxy S23 Ultra, Android 14:

I/FLUTTER_HEALTH(27526): Permission launcher not found

eric-nextsense · 2024-01-17T17:19:42Z

I created a fork of this pull request (and created a pull request with it to update this one) which fixes sleep read issues.

https://github.com/eric-nextsense/flutter-plugins/tree/health-connect-android-14-fix

tomassasovsky · 2024-01-17T20:08:46Z

Works perfectly, thanks @eric-nextsense!

limewareio · 2024-01-18T12:25:45Z

I'm getting the same error as @tomassasovsky - Permission launcher not found. I've tried referencing the https://github.com/eric-nextsense/flutter-plugins/tree/health-connect-android-14-fix repository in the pubspec.yaml file like this:

health:
    git:
      url: https://github.com/eric-nextsense/flutter-plugins
      path: packages/health
      ref: health-connect-android-14-fix

Any clues what might be wrong?

eliasteeny · 2024-01-18T18:27:35Z

Getting an error while testing on a Samsung Galaxy S23 Ultra, Android 14:

I/FLUTTER_HEALTH(27526): Permission launcher not found

I'm getting the same error as @tomassasovsky - Permission launcher not found. I've tried referencing the https://github.com/eric-nextsense/flutter-plugins/tree/health-connect-android-14-fix repository in the pubspec.yaml file like this:
health:
    git:
      url: https://github.com/eric-nextsense/flutter-plugins
      path: packages/health
      ref: health-connect-android-14-fix
Any clues what might be wrong?

Did you use FlutterFragmentActivity instead of FlutterActivity in the MainActivity file ?

hoffmatteo · 2024-01-22T13:25:24Z

Hi, I was finally able to test the PR and will include it in the upcoming release that will be coming late this week/early next week!

eric-nextsense · 2024-01-22T13:37:36Z

Did you include the additional changes to fix sleep that are in my branch? They were not merged in this fork by the author.

https://github.com/eric-nextsense/flutter-plugins/tree/health-connect-android-14-fix

eliasteeny · 2024-01-23T01:14:27Z

@eric-nextsense I didn't merge it because I was waiting to have some free time to also fix the writing of sleep data.

hoffmatteo · 2024-01-23T14:54:22Z

Did you include the additional changes to fix sleep that are in my branch? They were not merged in this fork by the author.

https://github.com/eric-nextsense/flutter-plugins/tree/health-connect-android-14-fix

Hi, I was just looking into the sleep issue. Your PR looks great, I added it to target health-dev and am looking into adding write functionality right now!

use registerForActivityResult instead of startActivityForResult

543edbc

eliasteeny mentioned this pull request Nov 17, 2023

[Health 8.0.0] ActivityNotFoundException when requesting for permission #800

Closed

chadpav mentioned this pull request Nov 18, 2023

Health Release 8.1.0 #832

Merged

chadpav approved these changes Nov 18, 2023

View reviewed changes

chadpav and others added 2 commits November 18, 2023 09:23

Update README.md for Android 14

3668d52

Merge pull request #2 from chadpav/patch-1

cd71d0f

Update README.md for Android 14

rickcasson mentioned this pull request Nov 21, 2023

Alpha6 updates and Mapping Fixes imdzx/flutter_health_connect#20

Open

hoffmatteo self-assigned this Nov 23, 2023

madhav-sunil reviewed Jan 10, 2024

View reviewed changes

hoffmatteo changed the base branch from master to health-dev January 22, 2024 13:28

Merge branch 'health-dev' into health-connect-android-14-fix

a9a0144

hoffmatteo merged commit 80ec67c into cph-cachet:health-dev Jan 22, 2024
1 check passed

hoffmatteo mentioned this pull request Jan 29, 2024

Release of Health 8.2.0 (compatability with Android 14) #884

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attempt to fix Health Connect on Android 14 #834

Attempt to fix Health Connect on Android 14 #834

eliasteeny commented Nov 17, 2023

chadpav commented Nov 18, 2023

chadpav left a comment •

edited

Loading

chadpav Nov 18, 2023

eliasteeny Nov 20, 2023

chadpav Nov 18, 2023

eliasteeny Nov 20, 2023

eric-nextsense Dec 19, 2023 •

edited

Loading

Letalus Dec 19, 2023

eric-nextsense Jan 8, 2024

eric-nextsense Jan 11, 2024

Letalus commented Dec 15, 2023

hoffmatteo commented Jan 2, 2024

Letalus commented Jan 8, 2024

madhav-sunil commented Jan 9, 2024 •

edited

Loading

madhav-sunil Jan 10, 2024

eliasteeny Jan 18, 2024

Alejandroem commented Jan 14, 2024

tomassasovsky commented Jan 17, 2024

eric-nextsense commented Jan 17, 2024

tomassasovsky commented Jan 17, 2024

limewareio commented Jan 18, 2024 •

edited

Loading

eliasteeny commented Jan 18, 2024

hoffmatteo commented Jan 22, 2024

eric-nextsense commented Jan 22, 2024

eliasteeny commented Jan 23, 2024

hoffmatteo commented Jan 23, 2024 •

edited

Loading

Attempt to fix Health Connect on Android 14 #834

Attempt to fix Health Connect on Android 14 #834

Conversation

eliasteeny commented Nov 17, 2023

chadpav commented Nov 18, 2023

chadpav left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eric-nextsense Dec 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Letalus commented Dec 15, 2023

hoffmatteo commented Jan 2, 2024

Letalus commented Jan 8, 2024

madhav-sunil commented Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Alejandroem commented Jan 14, 2024

tomassasovsky commented Jan 17, 2024

eric-nextsense commented Jan 17, 2024

tomassasovsky commented Jan 17, 2024

limewareio commented Jan 18, 2024 • edited Loading

eliasteeny commented Jan 18, 2024

hoffmatteo commented Jan 22, 2024

eric-nextsense commented Jan 22, 2024

eliasteeny commented Jan 23, 2024

hoffmatteo commented Jan 23, 2024 • edited Loading

chadpav left a comment •

edited

Loading

eric-nextsense Dec 19, 2023 •

edited

Loading

madhav-sunil commented Jan 9, 2024 •

edited

Loading

limewareio commented Jan 18, 2024 •

edited

Loading

hoffmatteo commented Jan 23, 2024 •

edited

Loading