-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Health] Add empty value check for calories
nutrition
#926
Closed
shubhamsinghmutualmobile
wants to merge
8
commits into
cph-cachet:bardram/health-update
from
shubhamsinghmutualmobile:bug/individual_nutrition_values
Closed
[Health] Add empty value check for calories
nutrition
#926
shubhamsinghmutualmobile
wants to merge
8
commits into
cph-cachet:bardram/health-update
from
shubhamsinghmutualmobile:bug/individual_nutrition_values
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Health] Add workout summary, manual entry and new health data types
…-mass-to-health-connect [Health] Add body water mass data type to health connect
[HEALTH] add new data type for STAND_TIME
shubhamsinghmutualmobile
changed the title
Add empty value check for
[Health] Add empty value check for Mar 26, 2024
calories
nutritioncalories
nutrition
bardram
approved these changes
Mar 30, 2024
Merged
Released as version 10.1.0 |
@bardram Also why did you "close" this when it's actually "merged"? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #925
Demo (iOS)
We don't have to provide unnecessary nutrition permissions anymore. In this example, I only wanted to add
caffeine
, hence, I only had to provide its permission.Screen.Recording.2024-03-26.at.8.20.44.PM.mov