[Health] Do not invoke method channel API when useHealthConnectIfAvailable is true on iOS #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #989.
According to the configure documentation:
If useHealthConnectIfAvailable is true, Google Health Connect on Android will be used. Has no effect on iOS.
However, setting useHealthConnectIfAvailable to true on iOS triggers calls to an unimplemented method Channel API.
To address this issue, I confirmed that no method Channel API is invoked when useHealthConnectIfAvailable is set to true and configure is called on iOS, thereby ensuring that the issue no longer occurs.
(I accidentally deleted the repository, so I have recreated the PR.)