Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft for build systems #93

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

diehlpk
Copy link

@diehlpk diehlpk commented May 17, 2024

First draft produced by during American group meeting.

#12

diehlpk and others added 2 commits May 17, 2024 16:34
@diehlpk
Copy link
Author

diehlpk commented Jul 26, 2024

@vulder @jcvw The US group discussed this pull request in today's meeting and we would move it to tentatively ready. We would appreciate to get feedback from the European group.

@vulder vulder requested review from vulder and jcvw October 2, 2024 07:00
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thanks for giving this topic a first version.

sources/modules/compilation-model/buildsystems.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Outdated Show resolved Hide resolved
@vulder vulder added Tentatively ready Ready for a final review in SG20 SG20-reviewed Reviewed by a SG20 meeting, ready to be merged after comment resolution. labels Oct 18, 2024
@ronchaine
Copy link

Should there be a mention of handling of (unit) testing, probably in advanced, as that is often handled by the build system? Not sure if it is better to mention here or not.

@diehlpk
Copy link
Author

diehlpk commented Oct 20, 2024

Should there be a mention of handling of (unit) testing, probably in advanced, as that is often handled by the build system? Not sure if it is better to mention here or not.

We could make a note that some build systems have this feature.

Mention unit testing
@diehlpk
Copy link
Author

diehlpk commented Oct 21, 2024

Should there be a mention of handling of (unit) testing, probably in advanced, as that is often handled by the build system? Not sure if it is better to mention here or not.

We could make a note that some build systems have this feature.

I added it to the latest commit

diehlpk and others added 3 commits October 20, 2024 21:06
Move building a lib and link it to a C++ executable to the main level
@diehlpk
Copy link
Author

diehlpk commented Oct 31, 2024

@vulder and @ronchaine I think I addressed all your comments.

Please have a look again.

@VictorEijkhout
Copy link

VictorEijkhout commented Oct 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SG20-reviewed Reviewed by a SG20 meeting, ready to be merged after comment resolution. Tentatively ready Ready for a final review in SG20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants