Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please merge: separate compilation #96

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

VictorEijkhout
Copy link

First attempt at "separate compilation" module.

@vulder vulder requested review from vulder and jcvw October 2, 2024 07:00
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first draft for the separate compilation topic.

Most of my comments are just align syntax/file structure with the rest of the topics. Overall, this topic highlights already many important points about the topic.

sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
Comment on lines 11 to 12
This module outlines the issues involved in using separate compilation on multiple program files.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module outlines the issues involved in using separate compilation on multiple program files.
This module outlines the issues involved in using separate compilation on multiple program files.

The overview normally does not contain pretext only the table with the different levels, maybe you could merge this text with the 'Motivation' below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would merge if I could. Gimme a hint where to do that?i in my fork? elsewhere?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was resolved in today's meeting.


A student:

1. needs to have the text editor skills to split a single-file program into multiple files.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to spell that out 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't hurt to spell it out.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it actually does: a) this needs is not really related to C++ and b) if we want to consistently specify student requirements with that granularity we need to add many other skills, too that all are not really related to C++.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing it. Go ahead and suggest it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was resolved in today's meeting.

sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
#### Points to cover

1. Cover the mechanisms for include and library paths to your own code, as well as discovery mechanisms for external libraries.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading the ASBATs, we probably need more points to cover that contain the skills necessary to reach the ASBAT level.

VictorEijkhout and others added 8 commits October 4, 2024 10:00
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
@diehlpk
Copy link

diehlpk commented Oct 21, 2024

refs #8

intro text moved to motivation
remove mention of text editor
turn enum list into item
remove incorrect sentence
TOC in sync with captions
added sentence about translation units
extern variable mention removed
@diehlpk
Copy link

diehlpk commented Oct 31, 2024

@vulder and @ronchaine we did a pass in today's meeting. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants