[lex.phases] Use preprocessing token consistently #7361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Oct 29, 2024
source/lex.tex
Outdated
Comment on lines
181
to
183
| \item Whitespace characters separating preprocessing tokens are no longer | ||
| significant. Each preprocessing token is converted into a | ||
| token\iref{lex.token}. The resulting tokens |
There was a problem hiding this comment.
Agreed with the rest of the changes, but this last paragraph would benefit from a bit of rephrasing:
"Each preprocessing token is converted into a token\iref..; whitespace characters separating tokens are no longer significant. The resulting tokens..."
There was a problem hiding this comment.
Amusingly, that distinction of preprocessor token before they were converted is what prompted this PR!
However, I agree that your reordering and preserving the existing use of just "token" is a better edit. Updated and pushed.
Prior to converting preprocessing tokens to tokens in phase 7, all tokens are strictly preprocessing tokens. Add the missing qualification is appropriate through the phases of translation up to that point of conversion.
AlisdairM
force-pushed
the
clarify_pp_tokens
branch
from
712fc29
to
4ca51f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to converting preprocessing tokens to tokens in phase 7, all tokens are strictly preprocessing tokens. Add the missing qualification is appropriate through the phases of translation up to that point of conversion.