-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use boost-cmake again #359
use boost-cmake again #359
Conversation
ClausKlein
commented
Jun 4, 2022
•
edited
Loading
edited
- the clone of the git repo takes to long time!
- and the boost CMake files are not really designed as modern CMake project!
- there is no central include directory!
- the boost CMake system is designed for boost developers to test there submodule
- every module lib that include an header of on other module lib depends on this lib, too if it may used as header-only lib!
1579641
to
680fc7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR, and sorry for the delay. I wasn't aware that boost still isn't properly CMake compatible. Could you also update the example in the Readme to reflect the change?
e3afbc8
to
5f67449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! I just noticed that you linked to your local fork instead of the "original" Orphis/boost-cmake package. I assume this is to support more recent releases for boost project, as @Orphis version doesn't have releases after 1.67.0. Two things worry me however.
- In case this becomes commonly used, are you completely sure you want to continue maintaining the project in the future? You could also end up breaking many peoples projects if you move the project or delete your GitHub account.
- I also wonder if it is a good idea in general to add very new projects or forks to prominent positions in the readme and examples, as it can create an impression that these are commonly used and long-term maintained packages.
In any case, I've seen that you've made a pull request to the original project, which I would prefer to use. Perhaps for now we can fallback to the last supported version here and upgrade again after your PR is merged?
Yes, this is my intention. If my pull request is ignored, we may transfer this repo to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If my pull request is ignored, we may transfer this repo to cpm-cmake or perhaps better to cmake.org?
I find moving it to the cpm-cmake
namespace a bit problematic as it would imply that we are interested in actively maintaining this fork, which I am not. However, if we make it very clear that the fork's only purpose is to allow more frequent contributions from the community I think could be ok with it. However I'd much prefer somebody more involved with the library to take ownership if the original author isn't interested in maintaining the project anymore (afaict the last updates were made over a year and the last release over 4 years ago).
@iboB any thoughts?
I am toying with the idea of proposing the addition CPM-ified and CPM-friendly packages to cpm-cmake. Though I don't yet have a robust enough concrete proposal. So for now I would vote against it. Note that people have started creating orgs for this on their own. For example this one @ClausKlein, perhaps @CraigHutchinson would agree to add the boost-cmake repo there? |
💯 this is why CMakePackageRepository exists to contain this sort of repository. The repo provides pure CMake project wrappers for things 'I've' needed recently but I hope it can build some momentum. Would be good to promote this somehow... I was pleasantly surprised it has been noticed already by osmosis! @ClausKlein Need to document the repo-request workflow but just message me and I can give you admin on |
@CraigHutchinson Do you something like this? https://github.com/ClausKlein/boost-cmake#readme |
6b7092b
to
ccd39cb
Compare
@ClausKlein any thoughts / progress on moving your fork to the CMakePackageRegistry org? |
No, at the moment I am working on boost v1.81.0 ... |
I've sent invites. I haven't used boost for a while but hear since 1.78 it includes CMake as a build options? I also hear its support is somewhat limited. |
Please note Why you should NOT use Boost git repo with CPM.cmake |
this is a workaround to reduce the build time update boost example after review
7db2d51
to
17ba5c6
Compare
thanks, pretty clear, certainly backs up what I heard! |
Okay, I realised that I can fork to the cmakepackageregistry. You are admin to the project so can sync as/when and keep the personal copy for dev 🚀 |
I give it up |