Switch to non-deprecated FetchContent_Populate syntax (research PR) #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLartians
changed the title
|
Closing as the new syntax seems to come with more side-effects than expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My own attempt at figuring out why #570 doesn't seem to satisfy our test cases and trying to understand what the differences between old and new syntax are. For one it seems that
FetchContent_GetPropertiesdoes not seem to give us the SOURCE and BINARY directory, as I would have expected, so we need to implement the parsing ourselves. Now it seems that the handling of git has changed, leading to issues with the relative URL and deleted source dir test cases.