Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply provider versions in examples #827

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeanduplessis
Copy link
Collaborator

Provider versions change constantly, and updating the examples in the docs with every release is not feasible.
Users of the docs sometimes end up installing very old versions of the providers, which results in a sub-optimal experience and the need for help.

This PR introduces two main changes:

  1. The provider version to be installed is set to the major version only, e.g., v1 instead of v1.2.3. This has the effect of installing the latest provider version of the v1 major release. Note this capability is limited to the Upbound Marketplace for the providers used in the Quickstart guide.
  2. Updates the example output where provider versions are listed all to v1.0.0 for consistency.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit d092324
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/6729e7ad4f623d0008a79902
😎 Deploy Preview https://deploy-preview-827--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🟢 up 3 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

content/master/concepts/providers.md Outdated Show resolved Hide resolved
content/master/getting-started/provider-azure.md Outdated Show resolved Hide resolved
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice experience update @jeanduplessis. A couple places to check if we could just use v1 instead. If you look at those and confirm with testing that v1 tag pulling works, then this looks good to me! 🙇‍♂️

Signed-off-by: Jean du Plessis <jean@upbound.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants