Add Status Condition Example #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalton-hill-0
force-pushed
the
adding-condition-example
branch
2 times, most recently
from
504a290
to
2546439
Compare
Adds comment demonstrating how to use status conditions to communicate with claim authors. Signed-off-by: dalton hill <dalton.hill.0@protonmail.com>
dalton-hill-0
force-pushed
the
adding-condition-example
branch
from
2546439
to
0a78eb4
Compare
negz
approved these changes
Sep 12, 2024
jbw976
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Looks like a unit test is failing now @dalton-hill-0, which is probably a legit failure3 since the responses/conditions were updated 😉
Can you take a look?
https://github.com/crossplane/function-template-go/actions/runs/10689551294/job/30072844787?pr=78
Signed-off-by: dalton hill <dalton.hill.0@protonmail.com>
|
@jbw976 Ah thanks for pointing that out. I have fixed the failure 🙂 |
jbw976
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Added or updated unit tests for my change.