Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to function-sdk-go:v0.3.0 #81

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

jbw976
Copy link
Member

@jbw976 jbw976 commented Sep 21, 2024

Description of your changes

This PR bumps this template repo up to the latest release of function-sdk-go:v0.3.0.

Release notes: https://github.com/crossplane/function-sdk-go/releases/tag/v0.3.0

Closes #80
Closes #72
Closes #71

I've tested this locally with the steps from the main README.md, all of which succeeed:

go generate ./...
go test ./...
docker build . --tag=runtime
crossplane xpkg build -f package --embed-runtime-image=runtime

I'll also take this for a test spin through the Write a Composition Function in Go guide in the docs.

I have:

Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976
Copy link
Member Author

jbw976 commented Sep 21, 2024

Ah, looks like Renovate was trying to do something similar with #80, but since this requires some manual updates to the xfn v1 types, I'll go ahead and set this PR to close that one (and a few others). Thank you though Renovate!

Looks like errors for building now though, I think because of the go version bump without also bumping the CI workflow files. I'll look into that too.

Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976
Copy link
Member Author

jbw976 commented Sep 21, 2024

Sweet, all checks (linting/building/etc.) are passing green now! 🟢

Copy link
Contributor

@blakeromano blakeromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM...

Although we should make a follow up issue once this is fixed in Crossplane Core crossplane/crossplane#5971 to update the package metadata api version.

@jbw976
Copy link
Member Author

jbw976 commented Sep 22, 2024

Docs update PR to update the go function guide as well: crossplane/docs#814

@jbw976
Copy link
Member Author

jbw976 commented Sep 22, 2024

Although we should make a follow up issue once this is fixed in Crossplane Core crossplane/crossplane#5971 to update the package metadata api version.

Good call @blakeromano, thanks for taking a look and thanks for that reminder! I've opened #82 to track that bump 👍

Copy link
Collaborator

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbw976 and @blakeromano 🙏

@phisco phisco merged commit 3556666 into crossplane:main Sep 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants