fix(threads): revert #1388 #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
andrewazores
removed
the
needs-triage
andrewazores
force-pushed
the
revert-vertexecutor
branch
4 times, most recently
from
692cd51
to
e83e369
Compare
7 tasks
|
Test image available: |
andrewazores
force-pushed
the
revert-vertexecutor
branch
from
e83e369
to
db10e6f
Compare
|
This PR/issue depends on:
|
maxcao13
previously approved these changes
Apr 24, 2023
andrewazores
force-pushed
the
revert-vertexecutor
branch
from
db10e6f
to
e6e8791
Compare
|
Test image available: |
andrewazores
force-pushed
the
revert-vertexecutor
branch
from
e6e8791
to
947aedf
Compare
|
Test image available: |
andrewazores
force-pushed
the
revert-vertexecutor
branch
from
947aedf
to
6f92881
Compare
|
Test image available: |
cryostatio#1388)" This reverts commit 39695d0.
Signed-off-by: Andrew Azores <aazores@redhat.com>
andrewazores
force-pushed
the
revert-vertexecutor
branch
from
6f92881
to
af7eafa
Compare
|
Test image available: |
|
Rebased several times to include changes to |
maxcao13
approved these changes
Apr 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
* Revert "fix(credentials): store JMX session credentials in ThreadLocal (#1388)" This reverts commit 39695d0. * compile fixes Signed-off-by: Andrew Azores <aazores@redhat.com> * fixup! Revert "fix(credentials): store JMX session credentials in ThreadLocal (#1388)" --------- Signed-off-by: Andrew Azores <aazores@redhat.com> (cherry picked from commit eaf801a)
andrewazores
added a commit
that referenced
this pull request
Apr 25, 2023
* Revert "fix(credentials): store JMX session credentials in ThreadLocal (#1388)" This reverts commit 39695d0. * compile fixes Signed-off-by: Andrew Azores <aazores@redhat.com> * fixup! Revert "fix(credentials): store JMX session credentials in ThreadLocal (#1388)" --------- Signed-off-by: Andrew Azores <aazores@redhat.com> (cherry picked from commit eaf801a) Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffRelated to #1448
Related to #1449
Depends on #1466
Back out #1388 completely. This will break JMX session credentials again but should put the threading interactions back into a working (still not proper) condition. Needs more thorough testing to be sure however.