build(version): update versions for 2.2.1-dev

[ebaron]

Related to: https://github.com/cryostatio/cryostat/issues/1118

[andrewazores]

lgtm

[tthvo]

Looks good to me! Just wondering about the choice of image tags here? Why snapshot and cryostat- (only Grafana?)?

[ebaron]

Looks good to me! Just wondering about the choice of image tags here? Why snapshot and cryostat- (only Grafana?)?

This is meant to get the latest 2.2.x builds. All the operand images except Grafana build with an image tag derived from the POM version. The Grafana Dashboard has no POM file or version variable of any kind in the source, perhaps this warrants changing. The CI instead uses the Git branch name for the image tag, thus cryostat-v2.2.

A drawback with this is that it won't work with our development image version detection:

cryostat-operator/internal/controllers/common/resource_definitions/resource_definitions.go

Lines 1105 to 1115 in 23cfadd

	// Matches image tags of the form "major.minor.patch"
	var develVerRegexp = regexp.MustCompile(`(?i)(:latest|SNAPSHOT|dev|BETA\d+)$`)
	func getPullPolicy(imageTag string) corev1.PullPolicy {
	// Use Always for tags that have a known development suffix
	if develVerRegexp.MatchString(imageTag) {
	return corev1.PullAlways
	}
	// Likely a release, use IfNotPresent
	return corev1.PullIfNotPresent
	}

This will lead to the pull policy being IfNotPresent, when we'd prefer Always.

[tthvo]

Right that makes sense! Thanks for explaining :D

[ebaron]

Right that makes sense! Thanks for explaining :D

No problem, I filed cryostatio/cryostat-grafana-dashboard#19 in response to this discussion.