Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(release): prepare for cryostat 2.4.0 release #642

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to https://github.com/cryostatio/cryostat/issues/1695

@andrewazores
Copy link
Member Author

/build_test

@mergify mergify bot added the safe-to-test label Oct 11, 2023
@andrewazores
Copy link
Member Author

@andrewazores
Copy link
Member Author

@aali309 @tthvo @ebaron is it expected for the update_release_draft check to not run anymore after #641 or some other related PR?

@aali309
Copy link
Contributor

aali309 commented Oct 11, 2023

@aali309 @tthvo @ebaron is it expected for the update_release_draft check to not run anymore after #641 or some other related PR?

I think it should not be running/expected to run on pull request? @tthvo

@tthvo
Copy link
Member

tthvo commented Oct 11, 2023

@aali309 @tthvo @ebaron is it expected for the update_release_draft check to not run anymore after #641 or some other related PR?

I think it should not be running/expected to run on pull request? @tthvo

Ohh no, it no longer runs on pull request as we opted out auto-labeller.

Reference: https://github.com/release-drafter/release-drafter#usage

@tthvo
Copy link
Member

tthvo commented Oct 11, 2023

So yeh, we should remove update_release_draft check :))

@andrewazores andrewazores merged commit ac9929e into cryostatio:main Oct 11, 2023
6 checks passed
@andrewazores andrewazores deleted the prepare-240-release branch October 11, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants