chore(strings): update user string #1164
Conversation
| @@ -79,7 +79,7 @@ | |||
| "MAXIMUM_SIZE": "Maximum size ({{unit}})", | |||
| "SAVE_CHANGES": "Save changes", | |||
| "TEMPLATE_HELPER_TEXT": "The Event Template to be applied to Automated Analysis recordings.", | |||
| "TEMPLATE_INVALID_WARNING": "WARNING: Setting a Target Template as a default template type configuration may not apply to all Target JVMs if the JVMs do not support them." | |||
| "TEMPLATE_INVALID_WARNING": "WARNING: Setting the Target Template as a default template type configuration may not apply to all Target JVMs if the JVMs do not support them." | |||
There was a problem hiding this comment.
I'm not sure about this change. It's describing event templates of the kind "Target", as opposed to "Custom":
There are usually at least two such Target Templates for any given target application.
This warning is to say that if you pick a Target Template, then this only makes sense if every other Target has that same kind of Template (matching by name).
To give a concrete example of such an invalid configuration:
I could select the Cryostat event template here, but any configuration using this template (Automated Analysis card, Automated Rule) would not be able to apply this event template to another target which doesn't have that same template:
There was a problem hiding this comment.
Ok I'll keep it how it is 👍
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated: https://github.com/cryostatio/cryostat/issues/1695