Problem: redundant copy in check validate

CHANGELOG.md

@@ -27,6 +27,7 @@
 * [#1488](https://github.com/crypto-org-chain/cronos/pull/1488) Enable optimistic execution.
 * [#1490](https://github.com/crypto-org-chain/cronos/pull/1490) Update cometbft to v0.38.8.
 * [#1491](https://github.com/crypto-org-chain/cronos/pull/1491) Free slice data in HasAtVersion.
+* [#1498](https://github.com/crypto-org-chain/cronos/pull/1498) Check validity with extractSliceBytes to avoid copying slice data.
 
 ### Bug Fixes
 

versiondb/tsrocksdb/iterator.go

@@ -23,7 +23,7 @@ func newRocksDBIterator(source *grocksdb.Iterator, prefix, start, end []byte, is
 		} else {
 			source.Seek(end)
 			if source.Valid() {
-				eoakey := moveSliceToBytes(source.Key()) // end or after key
+				eoakey := extractSliceBytes(source.Key()) // end or after key
 				if bytes.Compare(end, eoakey) <= 0 {
 					source.Prev()
 				}
@@ -75,7 +75,7 @@ func (itr *rocksDBIterator) Valid() bool {
 	// If key is end or past it, invalid.
 	start := itr.start
 	end := itr.end
-	key := moveSliceToBytes(itr.source.Key())
+	key := extractSliceBytes(itr.source.Key())
 	if itr.isReverse {
 		if start != nil && bytes.Compare(key, start) < 0 {
 			itr.isInvalid = true
@@ -143,3 +143,13 @@ func moveSliceToBytes(s *grocksdb.Slice) []byte {
 	copy(v, s.Data())
 	return v
 }
+
+// extractSliceBytes returns the underlying []byte from the given *Slice
+// without copying the data. Use this function with caution as the *Slice
+// should not be used after calling this function, as it is not marked as freed.
+func extractSliceBytes(s *grocksdb.Slice) []byte {
+	if !s.Exists() {
+		return nil
+	}
+	return s.Data()
+}