Problem: rocksdb 9.2.1 is not used #1511
Conversation
yihuang
requested review from
mmsqe and
thomas-nguy
and removed request for
a team
WalkthroughThis update primarily involves upgrading the RocksDB dependency from version 9.1.1 to 9.2.1 across multiple configuration files in the project. The changes ensure compatibility and potentially introduce performance and stability improvements. The primary areas of adjustment include various module definitions and hash values to reflect this upgrade, without altering any public APIs or exported entities. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.sumis excluded by!**/*.sumversiondb/go.sumis excluded by!**/*.sum
Files selected for processing (5)
- CHANGELOG.md (1 hunks)
- go.mod (1 hunks)
- gomod2nix.toml (1 hunks)
- nix/rocksdb.nix (1 hunks)
- versiondb/go.mod (1 hunks)
Files skipped from review due to trivial changes (3)
- go.mod
- gomod2nix.toml
- versiondb/go.mod
Additional context used
Markdownlint
CHANGELOG.md
28-28: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
25-25: null
No empty links(MD042, no-empty-links)
Additional comments not posted (2)
nix/rocksdb.nix (2)
23-23: LGTM! Version update approved.The RocksDB version has been successfully updated to
9.2.1.
29-29: LGTM! Hash update approved.The hash has been updated to match the new RocksDB version.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
Markdownlint
CHANGELOG.md
28-28: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (1)
CHANGELOG.md (1)
25-25: LGTM!The entry for the RocksDB upgrade to v9.2.1 is correct and consistent with the format of other entries.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.sumis excluded by!**/*.sumversiondb/go.sumis excluded by!**/*.sum
Files selected for processing (5)
- CHANGELOG.md (1 hunks)
- go.mod (1 hunks)
- gomod2nix.toml (1 hunks)
- nix/rocksdb.nix (1 hunks)
- versiondb/go.mod (1 hunks)
Files skipped from review due to trivial changes (2)
- go.mod
- versiondb/go.mod
Additional context used
Markdownlint
CHANGELOG.md
28-28: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (5)
nix/rocksdb.nix (2)
23-23: Version update approved.The
rocksdbversion has been updated from9.1.1to9.2.1.
29-29: Hash update approved.The hash value for
rocksdbhas been updated to match the new version.gomod2nix.toml (2)
461-461: Version update approved.The version of
github.com/linxGnu/grocksdbhas been updated fromv1.9.1tov1.9.2.
462-462: Hash update approved.The hash value for
github.com/linxGnu/grocksdbhas been updated to match the new version.CHANGELOG.md (1)
25-25: Changelog entry looks good.The entry correctly describes the upgrade of rocksdb to v9.2.1.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1511 +/- ##
===========================================
+ Coverage 17.54% 35.87% +18.33%
===========================================
Files 87 136 +49
Lines 5273 9809 +4536
===========================================
+ Hits 925 3519 +2594
- Misses 4238 5894 +1656
- Partials 110 396 +286 |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
Markdownlint
CHANGELOG.md
28-28: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (1)
CHANGELOG.md (1)
25-25: Changelog entry looks good!The new entry for upgrading RocksDB to version 9.2.1 is correctly formatted and includes the appropriate PR link.
* Update CHANGELOG.md Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com> --------- Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com>
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
rocksdbto version9.2.1.github.com/linxGnu/grocksdbto version1.9.2.