Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: v1.4.0-rc3 not released #1675

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 6, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features

    • Added support for registering payees and counterparty payees in the relayer precompile.
    • Introduced a benchmark command for the testnet.
  • Bug Fixes

    • Updated iavl dependency to resolve a pruning issue.
  • Improvements

    • Updated cometbft library to version 0.38.13.
    • Implemented asynchronous transaction checks and performance optimizations, including faster proposal preparation and parallel transaction checks.
  • Documentation

    • Updated the CHANGELOG.md to reflect the latest version and changes.

Copy link
Contributor

coderabbitai bot commented Nov 6, 2024

Walkthrough

The CHANGELOG.md file has been updated to document the release of version v1.4.0-rc3, dated November 6, 2024. This update includes a summary of bug fixes, new features, and improvements, such as an updated iavl dependency, support for registering payees in the relayer precompile, and enhancements to the cometbft library. Performance optimizations and the addition of a benchmark command for the testnet are also noted. The changelog maintains a clear structure, preserving information from previous releases.

Changes

File Change Summary
CHANGELOG.md Updated for version v1.4.0-rc3 to include bug fixes, features, and improvements. Notable updates include iavl dependency fix, payee registration support, cometbft library update, asynchronous transaction checks, and performance optimizations. Previous version v1.4.0-rc2 details retained.

Possibly related PRs

Suggested reviewers

  • thomas-nguy
  • mmsqe
  • calvinaco

🐇 "In the changelog, updates abound,
For version v1.4.0-rc3, joy is found.
Payees registered, bugs fixed with care,
Improvements and features, all laid bare.
Hopping through changes, we celebrate,
A brighter future, oh, isn’t it great!" 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yihuang yihuang marked this pull request as ready for review November 6, 2024 11:20
@yihuang yihuang requested a review from a team as a code owner November 6, 2024 11:20
@yihuang yihuang requested review from mmsqe and leejw51crypto and removed request for a team November 6, 2024 11:20
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

3-4: Consider using proper heading format for dates.

The dates in the changelog are currently formatted using emphasis (*date*). Consider using proper markdown heading format for better document structure.

Example change:

-*Nov 6, 2024*
+### Nov 6, 2024
🧰 Tools
🪛 Markdownlint

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 742d12f and 6b77c9d.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

@yihuang yihuang added this pull request to the merge queue Nov 6, 2024
Merged via the queue into crypto-org-chain:main with commit 9469907 Nov 6, 2024
38 checks passed
@yihuang yihuang deleted the rc3 branch November 6, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants