only log CreateVaultEvent if it's actually creating and not updating

cryptomator · Jul 11, 2023 · 72150ea · 72150ea
1 parent d31e0ee
commit 72150ea
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/backend/src/main/java/org/cryptomator/hub/api/VaultResource.java b/backend/src/main/java/org/cryptomator/hub/api/VaultResource.java
@@ -363,17 +363,13 @@ public Response createOrUpdate(@PathParam("vaultId") UUID vaultId, @Valid @NotNu
 		vault.name = vaultDto.name;
 		vault.description = vaultDto.description;
 		vault.archived = vaultDto.archived;
-
-		try {
-			vault.persistAndFlush();
+		vault.persistAndFlush();
+		if (isCreated) {
 			CreateVaultEvent.log(currentUser.id, vault.id);
-			if (isCreated) {
-				return Response.created(URI.create(".")).contentLocation(URI.create(".")).entity(VaultDto.fromEntity(vault)).type(MediaType.APPLICATION_JSON).build();
-			} else {
-				return Response.ok(VaultDto.fromEntity(vault), MediaType.APPLICATION_JSON).build();
-			}
-		} catch (PersistenceException e) {
-			throw new InternalServerErrorException(e);
+			return Response.created(URI.create(".")).contentLocation(URI.create(".")).entity(VaultDto.fromEntity(vault)).type(MediaType.APPLICATION_JSON).build();
+		} else {
+			// TODO: log UpdateVaultEvent
+			return Response.ok(VaultDto.fromEntity(vault), MediaType.APPLICATION_JSON).build();
 		}
 	}