Skip to content

Fix parser not using config enclosure for read_full_record - #17

Open
Kwanddwo wants to merge 3 commits into
csvtoolkit:mainfrom
Kwanddwo:fix-parser-config-enclosure
Open

Fix parser not using config enclosure for read_full_record#17
Kwanddwo wants to merge 3 commits into
csvtoolkit:mainfrom
Kwanddwo:fix-parser-config-enclosure

Conversation

@Kwanddwo

@Kwanddwo Kwanddwo commented Jul 2, 2026

Copy link
Copy Markdown
Contributor
  • Fixed parser using " directly instead of config->enclosure in read_full_record
  • Added custom enclosure and custom delimiter tests
  • Changed functions where necessary to send config to read_full_record

This fixes #11

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4a7edda7-fa6f-4731-b0c4-7faa53d7c81d

📥 Commits

Reviewing files that changed from the base of the PR and between cc93661 and 081bbf3.

📒 Files selected for processing (6)
  • csv_parser.c
  • csv_parser.h
  • csv_reader.c
  • csv_reader.h
  • tests/test_csv_parser.c
  • tests/test_csv_reader.c
👮 Files not reviewed due to content moderation or server errors (6)
  • csv_reader.c
  • csv_reader.h
  • tests/test_csv_parser.c
  • csv_parser.c
  • csv_parser.h
  • tests/test_csv_reader.c

📝 Walkthrough

[!WARNING]

Walkthrough skipped

File diffs could not be summarized.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSV parser uses quotation marks as enclosure instead of config->enclosure

1 participant