This repository has been archived by the owner on May 28, 2019. It is now read-only.
Let the Java JSON Formatter handle output and embeddings in hooks #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have run into issues with Java JSON Formatter using the write(String) and embedding(String, byte[]) methods. In particular List is output as a Java OID, not as a JSON array. I would be desirable to use the existing JSON Formatter to add some custom output than re-implement a Formatter and Reporter just to capture that additional data. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cucumber/cucumber-jvm#638 showed that the Java JSON Formatter does not handle output and embeddings in hooks properly (that is calls to cucumber.api.scenario.write() and cucumber.api.scenario.embed() in hooks). This PR should fix this.