Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Metal Performance Shaders #125

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Tps-F
Copy link

@Tps-F Tps-F commented Feb 17, 2024

To be able to work with mps devices
mpsデバイスで動作ができるように

check status

  • benchmark
  • img2img
  • txt2img
  • vid2vid

@Tps-F Tps-F marked this pull request as ready for review February 17, 2024 14:39
@Tps-F
Copy link
Author

Tps-F commented Feb 17, 2024

Benchmark results on m1 macbook air

Average time: 4233.89050291ms
Average FPS: 0.23618938640777057
Max FPS: 0.2696536167593899
Min FPS: 0.16658852853947326
Std: 0.023981565291716123

@Tps-F
Copy link
Author

Tps-F commented Feb 18, 2024

Should I make the demo work on mps too?

@Hugofgx9
Copy link

Hugofgx9 commented Mar 3, 2024

Hey @Tps-F, I'm interesting by your pr. Could you explain how to install and use it on mps ?

@cumulo-autumn
Copy link
Owner

@Tps-F
Hi, sorry for the late reply. The implementation for mps devices looks very interesting! We're quite busy this week and cannot review your code at the moment, but I'll make sure to review your pull request (PR) next week. Thank you so much!

@Tps-F
Copy link
Author

Tps-F commented Mar 4, 2024

@Hugofgx9 Thanks for your interest!

xformer doesn't support mps, so don't install it, just follow the instructions in the readme.
To install pytorch, choose the one that fits your environment from here
https://pytorch.org/

I'll add a more detailed guide to the PR later.

@Tps-F
Copy link
Author

Tps-F commented Mar 4, 2024

@cumulo-autumn
Thank you for stopping by and taking time out of your busy schedule!
I may make a few more changes, so I'll have it done by next week.

@Hugofgx9
Copy link

Hugofgx9 commented Mar 4, 2024

@Tps-F Thanks for your work and explanations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants