Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppeteer v22 #1837

Closed
wants to merge 2 commits into from
Closed

Puppeteer v22 #1837

wants to merge 2 commits into from

Conversation

raineorshine
Copy link
Contributor

No description provided.

@raineorshine
Copy link
Contributor Author

raineorshine commented Apr 26, 2024 •
edited
Loading

Puppeteer tests failing with error:

Cannot find module 'puppeteer-core/internal/puppeteer-core.js' from 'node_modules/puppeteer/lib/cjs/puppeteer/puppeteer.js'

    Require stack:
      node_modules/puppeteer/lib/cjs/puppeteer/puppeteer.js
      src/e2e/puppeteer/helpers/setup.ts
      src/e2e/puppeteer/helpers/index.ts
      src/e2e/puppeteer/__tests__/cursor.ts

Seems like jest needs to be at least v28 or v29 to fix this issue. This requires coordinated upgrades of jest and jest-environment-puppeteer-jsdom, which currently breaks the test setup.

@raineorshine
Copy link
Contributor Author

Puppeteer upgraded in 160c50b

@raineorshine raineorshine deleted the puppeteer-v22 branch September 19, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raineorshine